Skip to content

Commit

Permalink
remove 'type' param from renko_params
Browse files Browse the repository at this point in the history
  • Loading branch information
coffincw committed Mar 7, 2020
1 parent de07cd0 commit 409fe6b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion src/mplfinance/_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,6 @@ def _construct_renko_collections(dates, highs, lows, renko_params, closes, marke
marketcolors = _get_mpfstyle('classic')['marketcolors']
print('default market colors:',marketcolors)

renko_type = renko_params['type']
brick_size = renko_params['brick_size']
atr_length = renko_params['atr_length']

Expand All @@ -316,6 +315,7 @@ def _construct_renko_collections(dates, highs, lows, renko_params, closes, marke

if brick_size == 'atr':
brick_size = calculate_atr(atr_length, highs, lows, closes)
print(brick_size)

alpha = marketcolors['alpha']

Expand Down
2 changes: 0 additions & 2 deletions src/mplfinance/plotting.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,6 @@ def _valid_renko_kwargs():
kwarg value is one of the allowed values.
'''
vkwargs = {
'type' : { 'Default' : 'pmove',
'Validator' : lambda value: value in ['pmove','pclose'] },
'brick_size' : { 'Default' : 2.0,
'Validator' : lambda value: isinstance(value,float) or isinstance(value,int) or value == 'atr' },
'atr_length' : { 'Default' : 14,
Expand Down

0 comments on commit 409fe6b

Please sign in to comment.