Issues/80 add technology and difficulty #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belavina
reviewed
Jun 17, 2019
Github/package.json
Outdated
| "express": "^4.16.3", | ||
| "jquery": "^3.3.1", | ||
| "path": "^0.12.7", | ||
| "prettier": "^1.18.2", |
There was a problem hiding this comment.
Shouldn't these go to "devDependencies"? @poftadeh @manekenpix
There was a problem hiding this comment.
Yes, but linting is covered in #28, so I would recommend not committing these packages yet.
There was a problem hiding this comment.
I'll remove prettier then.
belavina
requested changes
Jun 17, 2019
poftadeh
suggested changes
Jun 17, 2019
Github/service.js
Outdated
| }); | ||
| } | ||
| filteredIssues.push({ | ||
| const labelsInIssue = issue.labels.map(label => { |
There was a problem hiding this comment.
Can be an implicit return: issue.labels.map(label => label.name);
Github/package.json
Outdated
| "express": "^4.16.3", | ||
| "jquery": "^3.3.1", | ||
| "path": "^0.12.7", | ||
| "prettier": "^1.18.2", |
There was a problem hiding this comment.
Yes, but linting is covered in #28, so I would recommend not committing these packages yet.
Merged
belavina
previously approved these changes
Jun 19, 2019
poftadeh
previously approved these changes
Jun 19, 2019
belavina
approved these changes
Jun 19, 2019
poftadeh
approved these changes
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #80
Added
labelstohelp-wantedso nowdifficultyis available for display. It hasn't been decided iftechnologywill be added using labels or the issue's text, so right nowrepository.languageis what provides information abouttechnology.Also,
forEachloops andifstatements were replaced (when possible) withmap()andfilter().