-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #3565: Post user avatar not using proper GitHub image #3703
Fixes #3565: Post user avatar not using proper GitHub image #3703
Conversation
3026cef
to
333d50c
Compare
333d50c
to
2f5ff87
Compare
2f5ff87
to
966e99e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing, I've always wanted this! Thanks for doing it.
One question I have for a follow-up: this isn't using
telescope/src/db/prisma/schema.prisma
Line 77 in cd4d285
github_avatar_url String |
cc @DukeManh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
966e99e
to
5a11d85
Compare
I'm not sure, I think it's not used anywhere else, but I'm not very familiar with how we use supabase, so maybe I'm missing something. |
Filed #3704 |
Issue This PR Addresses
Fixes #3565
Type of Change
Description
This PR adds changes to send the
github
username of a telescope user (if stored) to the frontend and use it to display the user'sgithub
avatar in posts.Steps to test the PR
db:init
script to add feeds to the database.telescope_profiles
table with validgithub
usernames and link them to users in thefeeds
table by using the same id intelescope_profiles->id
andfeeds->user_id
.github
username display the user'sgithub
avatar, and the user's initials when there's nogithub
username stored.Checklist