Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency octokit to v3 [security] #3848

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 16, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
octokit 2.0.9 -> 3.1.2 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2023-50728

Impact

Versions v9.26.0, v10.9.x), v11.1.x, v12.0.x all contained the code that would throw the error.

Specifically, during a pentest we encountered a bug in the octokit/webhooks library (a dependency of Probot, a framework for building Github Apps). The resulting request was found to cause an uncaught exception that ends the nodejs process.

The problem is caused by an issue with error handling in the @​octokit/webhooks library because the error can be undefined in some cases.

Credit goes to @​pb82 (for the early analysis) and @​rh-tguittet (for discovery).

Patches

Maintenance releases for the Error being thrown by the verify method in octokit/webhooks.js

Maintenance release for the reference for octokit/webhooks.js in app.js

Maintenance release for the reference for octokit/webhooks.js in octokit.js

Maintenance release for the reference for octokit/webhooks.js in Protobot

Workarounds

It is recommend that all users upgrade to the latest version of octokit/webhooks.js or use one of the updated back ported versions.


Release Notes

octokit/octokit.js (octokit)

v3.1.2

Compare Source

Bug Fixes
  • updates app.js for the handling of an error being thrown by the verify method in webhooks.js (#​2576) (b59da80)

v3.1.1

Compare Source

Bug Fixes

v3.1.0

Compare Source

Features

v3.0.0

Compare Source

Features
BREAKING CHANGES
  • Drop support for NodeJS v14, v16
  • Remove previews support for the REST API
  • remove agent option from octokit.request()
  • Replace support for Node.js http(s) Agents with documentation on using fetch dispatchers instead (via @octokit/request)
  • Remove ability to pass custom request options, except for method, headers, body, signal (via @​octokit/request)

v2.1.0

Compare Source

Features

v2.0.22

Compare Source

Bug Fixes

v2.0.21

Compare Source

Bug Fixes

v2.0.20

Compare Source

Bug Fixes

v2.0.19

Compare Source

Bug Fixes

v2.0.18

Compare Source

Bug Fixes

v2.0.17

Compare Source

Bug Fixes

v2.0.16

Compare Source

Bug Fixes

v2.0.15

Compare Source

Bug Fixes

v2.0.14

Compare Source

Bug Fixes

v2.0.13

Compare Source

Bug Fixes

v2.0.12

Compare Source

Bug Fixes

v2.0.11

Compare Source

Bug Fixes

v2.0.10

Compare Source

Bug Fixes

Configuration

📅 Schedule: Branch creation - "" in timezone America/Toronto, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Dec 16, 2023
Copy link
Contributor Author

renovate bot commented Dec 16, 2023

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: pnpm-lock.yaml
 WARN  The "store" setting has been renamed to "store-dir". Please use the new name.
 ERR_PNPM_UNSUPPORTED_ENGINE  Unsupported environment (bad pnpm and/or Node.js version)

Your pnpm version is incompatible with "/tmp/renovate/repos/github/Seneca-CDOT/telescope".

Expected version: >=8
Got: 6.32.13

This is happening because the package's manifest has an engines.pnpm field specified.
To fix this issue, install the required pnpm version globally.

To install the latest version of pnpm, run "pnpm i -g pnpm".
To check your pnpm version, run "pnpm -v".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants