Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jcifs-ng latest release #2

Open
wants to merge 3 commits into
base: 1.10
Choose a base branch
from

Conversation

PhilZ-cwm6
Copy link

  • Upgrade jcifs-ng to 2.1.7
  • Recompile smb v1 jcifs to use jcifs13 class
  • For simpler maintenance, upgrade latest jcifs-ng class to jcifs

- Upgrade jcifs-ng to 2.1.7
- Recompile smb v1 jcifs to use jcifs13 class
- For simpler maintenance, upgrade latest jcifs-ng class to jcifs
@PhilZ-cwm6
Copy link
Author

PhilZ-cwm6 commented May 27, 2022

For simpler maintenance, I renamed the jcifs-ng latest class as in main sources, that is jcifs
I changed jcifs v1.3.17 class to jcifs13

In the future, updating jcifs is a matter of compiling original source with small changes to fix compiler issues. Major changes are only needed if you want to change the latest 2.14 for example to 2.16...

Edit: note that I had to revert the upgrade of bouncycastle fix. It will need to be first added to eclipse dependencies to fix compiler errors. However, for 2.1.7, it has no impact on current code.

this upgrades jcifs-ng lib to match upstream source logging code using braces formatting
Update jcifs-ng with bouncycastle.org bcprov-jdk15to18-169
(only upstream source changes, compiled code is the same)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant