Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream merge 8 #196

Merged
merged 67 commits into from
Aug 10, 2023
Merged

Upstream merge 8 #196

merged 67 commits into from
Aug 10, 2023

Conversation

TheArturZh
Copy link
Member

@TheArturZh TheArturZh commented Aug 10, 2023

Описание PR

мерж обновлений с апстрима (фикс identity)

Медиа

Проверки

  • PR полностью завершён и мне не нужна помощь чтобы его закончить.
  • Я внимательно просмотрел все свои изменения и багов в них не нашёл.
  • Я запускал локальный сервер со своими изменениями и всё протестировал.
  • Я добавил скриншот/видео демонстрации PR в игре, или этот PR этого не требует.

Изменения

🆑 TheArturZh

  • add: Добавлены обновления от оффов

Vordenburg and others added 30 commits August 8, 2023 10:10
The access configurator programs the access levels of any access reader. To use the access configurator, players must:

- Insert an ID card
- Click a nearby entity with an access reader with the access configurator in hand
- Change the access list

Note that players only need one of the access levels listed on the device to lock/unlock it, but will only be able to alter access settings when they all of the access levels listed on the device

For example, an airlock which has 'Science' and 'Engineering' access listed can be opened by any player with either 'Science' or 'Engineering' access. However, to change the access settings on this airlock, a player must have both 'Science' and 'Engineering' access. This is to prevent people from easily breaking into secure areas with this tool, by adding one of their own access levels to the target device

Obviously, the most useful ID card to use with this tool is one with all access, since it can change the settings of any device. Removing all access requirements from a device will make it useable by anyone.

---------

Co-authored-by: Kevin Zheng <[email protected]>
* Maintenance fluffing

* And the gas analyzer
Disables wheelchair trait, vehicle code needs to be fixed
* saltern teg groundworks

* pro totype

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
…zards#18898)

* replaces CEV=eris rock sprites with /tg/ ones, removes mountainrock, adds ironrock

* phew... good thing i'm purple

* Update Resources/Prototypes/Entities/Structures/Walls/asteroid.yml

Co-authored-by: Vordenburg <[email protected]>

---------

Co-authored-by: Vordenburg <[email protected]>
* changes

* fix test fail hopefully

* disallow eating containers

* no more eating stored stuff
While here, change the crates that look plastic to actually be made of plastic so they don't reflect.
Apparently trying to anchor an entity twice throws an assert!
PJBot and others added 21 commits August 9, 2023 22:04
I'm not entirely sure what happens, I know it's markings being loaded from DB with the same ID as a prototype that was modified don't jive, but I'm not entirely sure if it's the best fix.
* Adds Sechud to lockers and sec techfab

* Add sechud to HOS lockers.
* Adds the ability to better protect to the internal wiring of airlocks
- Achieved by opening the maintenance panel, adding either steel or plasteel to the airlock, then welding the plate in place
- To access the wiring, the plating must be cut with a welder and then pried out with a crowbar

* Code revisions
- Cleaned up the code
- Cutting the security grille can now shock you
- Atmospherics and Security dept airlocks start with a medium level of protection (a welded steel plate)
- Command dept airlocks start with a high level of protection (a welded plasteel plate and electrified security grille)

* Code revision
- Accounted for a potentially null string

* Update Content.Server/Construction/Completions/AttemptElectrocute.cs

Co-authored-by: Slava0135 <[email protected]>

* Update ChangeWiresPanelSecurityLevel.cs

Adjusted scope

* Update Content.Shared/Wires/SharedWiresSystem.cs

Co-authored-by: Slava0135 <[email protected]>

* Update Content.Shared/Wires/SharedWiresSystem.cs

Co-authored-by: Slava0135 <[email protected]>

* Update ChangeWiresPanelSecurityLevel.cs

Removed get / setter and added [ValidatePrototypeId] attribute

* Update ChangeWiresPanelSecurityLevel.cs

Set security level to "Level0" as the default

* Update airlock.yml

Removed 'super max' level of security

* Update WiresPanelSecurityLevelPrototype.cs

* Update WiresSystem.cs

Added check for WiresAccessible to OnInteractUsing

* Update AttemptElectrocute.cs

File scoped namespace

* Update ChangeWiresPanelSecurityLevel.cs

File scoped namespace

* Update AirlockSystem.cs

File scoped namespace

* Update SharedWiresSystem.cs

Removed boiler plate 'OnGetState' and 'OnHandleState'

* Update WiresPanelComponent.cs

Implemented AutoGenerateComponentState

* Removed unnecessary usage references

* use TryCloseAll when wires not accessible

* minor changes to AttemmptElectrocute

* lets try all 7 levels

* fix indent in airlock graph

* fix indent 2

---------

Co-authored-by: Slava0135 <[email protected]>
Co-authored-by: Slava0135 <[email protected]>
* remove request computer board steal objective

* this thing, too
@github-actions
Copy link

github-actions bot commented Aug 10, 2023

RSI Diff Bot; head commit d7d3e8f merging into 6d507ab
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Uniforms/Jumpskirt/qm.rsi

State Old New Status
inhand-left Modified
inhand-right Modified

Resources/Textures/Clothing/Uniforms/Jumpsuit/qm.rsi

State Old New Status
equipped-INNERCLOTHING-monkey Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/Mobs/Customization/human_hair.rsi

State Old New Status
modern Modified

Resources/Textures/Objects/Devices/nuke.rsi

State Old New Status
nuclearbomb_base Modified
nuclearbomb_exploding Modified
nuclearbomb_timing Modified
nuclearbomb_safetyoff Removed
nuclearbomb_deployed Added
nuclearbombc Added

Resources/Textures/Objects/Weapons/Guns/Launchers/grappling_gun.rsi

State Old New Status
base-unshaded-off Modified
base-unshaded Modified
base Modified
hook Modified
inhand-left Modified
inhand-right Modified
rope Modified
hook-unshaded Removed
inhand-left-unshaded Removed
inhand-right-unshaded Removed

Resources/Textures/Mobs/Customization/Moth/moth_wings.rsi

State Old New Status
dbushy Removed
deathhead Removed
firewatch Removed
moffra Removed
plasmafire Removed
royal Removed
dbushy_primary Added
dbushy_secondary Added
deathhead_primary Added
deathhead_secondary Added
firewatch_primary Added
firewatch_secondary Added
moffra_primary Added
moffra_secondary Added
plasmafire_primary Added
plasmafire_secondary Added
royal_primary Added
royal_secondary Added

Resources/Textures/Structures/Walls/asteroid_rock.rsi

State Old New Status
full Removed
rock_0 Removed
rock_1 Removed
rock_2 Removed
rock_3 Removed
rock_4 Removed
rock_5 Removed
rock_6 Removed
rock_7 Removed

Resources/Textures/Structures/Walls/mountain_rock.rsi

State Old New Status
full Removed
rock_0 Removed
rock_1 Removed
rock_2 Removed
rock_3 Removed
rock_4 Removed
rock_5 Removed
rock_6 Removed
rock_7 Removed

Resources/Textures/Clothing/Uniforms/Jumpskirt/qmturtleskirt.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/Clothing/Uniforms/Jumpsuit/qmturtle.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/Objects/Consumable/Food/condiments.rsi

State Old New Status
packet-mustard Added

Resources/Textures/Objects/Tools/access_configurator.rsi

State Old New Status
equipped-BELT Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/Objects/Weapons/Guns/Battery/disabler.rsi

State Old New Status
inhand-left Added
inhand-right Added

Resources/Textures/Structures/Walls/rock.rsi

State Old New Status
ironrock Added
ironrock_east Added
ironrock_north Added
ironrock_south Added
ironrock_west Added
rock_asteroid Added
rock_asteroid_east Added
rock_asteroid_north Added
rock_asteroid_south Added
rock_asteroid_west Added

Edit: diff updated after d7d3e8f

@TheArturZh
Copy link
Member Author

Оффы сломали тесты, на локалке проходят все кроме двух поломанных оффами.

@TheArturZh TheArturZh merged commit 9b8fb66 into SerbiaStrong-220:master Aug 10, 2023
20 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.