https option #18
Merged
https option #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If set to true, https is used instead of http. Default is true.
|
Thanks for opening a PR! I'm not sure what use case there might be for hitting an S3 URL without HTTPS is though - left a comment saying the same on that issue. |
|
https://docs.aws.amazon.com/AmazonS3/latest/userguide/WebsiteEndpoints.html It does not support SSL connections |
|
I see, thanks for sharing. It's not entirely clear to me that those website endpoints support uploading... That said, since you default to the current behavior, I don't see any reason against adding support for this. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If set to true, https is used instead of http. Default is true.
Refer to: http https option #17