Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gsm8k scripts and readme #33

Merged
merged 9 commits into from
Oct 2, 2024
Merged

update gsm8k scripts and readme #33

merged 9 commits into from
Oct 2, 2024

Conversation

ollmer
Copy link
Collaborator

@ollmer ollmer commented Sep 27, 2024

Replace all Jupyter notebooks in the gsm8k examples with command line scripts.

@ollmer ollmer requested a review from rizar September 30, 2024 16:29
@rizar
Copy link
Collaborator

rizar commented Oct 1, 2024

so this PR has the word "readme" in it, but I can't see it in the list of files. Should it be there? Should I review?

@ollmer
Copy link
Collaborator Author

ollmer commented Oct 1, 2024

My bad, readme is missing, will add it in a few hours.

@ollmer
Copy link
Collaborator Author

ollmer commented Oct 2, 2024

@rizar Readme is ready

Copy link
Collaborator

@rizar rizar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

examples/gsm8k_tuning/README.md Show resolved Hide resolved
@ollmer ollmer merged commit df0b5ad into main Oct 2, 2024
2 checks passed
@ollmer ollmer deleted the gsm8k_scripts branch October 2, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants