Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplified intro notebook #34

Merged
merged 11 commits into from
Sep 28, 2024
Merged

Simplified intro notebook #34

merged 11 commits into from
Sep 28, 2024

Conversation

jpt-sn
Copy link
Collaborator

@jpt-sn jpt-sn commented Sep 27, 2024

No description provided.

@rizar rizar self-requested a review September 27, 2024 20:58
rizar
rizar approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@rizar rizar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Please add metadata.prompt_id to the steps in Cell 10, otherwise the example doesn't work.

(we should cover the cell outputs by tests as well, this would have caught this bug)

@jpt-sn jpt-sn changed the title [WIP] Simplified intro notebook Simplified intro notebook Sep 28, 2024
@jpt-sn jpt-sn merged commit d2f842a into main Sep 28, 2024
2 checks passed
@jpt-sn jpt-sn deleted the intro-simplified branch September 28, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rizar rizar rizar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpt-sn @rizar