Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TapeBrowser render tape #95

Merged
merged 3 commits into from
Nov 12, 2024
Merged

TapeBrowser render tape #95

merged 3 commits into from
Nov 12, 2024

Conversation

jpt-sn
Copy link
Collaborator

@jpt-sn jpt-sn commented Nov 9, 2024

Closes #93.

  • Add TapeBrowser for Data Science Example. (It would be great to add TapeType as part of Tape metadata so we could dynamically open different tapes type with same script/app)
  • TapeBrowser use render_tape to reuse renderer codebase
  • TapeBrowser HTML support local image from output folder
image

@jpt-sn jpt-sn requested a review from ollmer November 9, 2024 05:03
@rizar
Copy link
Collaborator

rizar commented Nov 12, 2024

Add TapeBrowser for Data Science Example. (It would be great to add TapeType as part of Tape metadata so we could dynamically open different tapes type with same script/app)

More broadly speaking, it would be good to have a class registry that we could use to deserialize more kinds of objects from the framework, such as Tapes, Agents, Nodes. We can prioritize this if we have target audience.

Copy link
Collaborator

@rizar rizar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! thanks, @jpt-sn !

@ollmer are you okay with this PR?
@jpt-sn I think you can remove the search for SQLite DB from browse.py

examples/data_science/browse.py Outdated Show resolved Hide resolved
@ollmer
Copy link
Collaborator

ollmer commented Nov 12, 2024

Looks great! I have only 1 minor suggestion, stated above.

@jpt-sn jpt-sn merged commit 9f54a00 into main Nov 12, 2024
2 checks passed
@jpt-sn jpt-sn deleted the tape-browser-render-tape branch November 12, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tape browser should use render_tape
3 participants