Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow content field to be empty. #81

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Allow content field to be empty. #81

merged 1 commit into from
Sep 23, 2024

Conversation

jarekmajcher
Copy link
Contributor

No description provided.

@loevgaard
Copy link
Member

Hi, @jarekmajcher

Thanks for your PR :-)

Could you explain the use case?

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.67%. Comparing base (a631fe3) to head (a86c308).
Report is 2 commits behind head on 2.x.

Additional details and impacted files
@@           Coverage Diff           @@
##               2.x     #81   +/-   ##
=======================================
  Coverage     3.67%   3.67%           
  Complexity      96      96           
=======================================
  Files           18      18           
  Lines          517     517           
=======================================
  Hits            19      19           
  Misses         498     498           
Flag Coverage Δ
3.67% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jarekmajcher
Copy link
Contributor Author

Hi @loevgaard ,
I was guided by the description of the "content" field in the administrator panel.

If the content is empty the label next to the checkbox will not have a link

In my case, I use BitBagCmsPlugin where I store all the regulations and I don't want to duplicate their content in another place. Leaving the "content" field empty allows me to manually provide a link in the content of the checkbox using html.

When I complete the "content" field and the label field does not contain [link:Link text], then the entire checkbox label is a link to the privacy policy.

@loevgaard loevgaard merged commit 96ca91a into Setono:2.x Sep 23, 2024
30 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants