Base server #1
Open
Base server #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ShamanEstBanan
commented
Apr 16, 2023
•
ShamanEstBanan
commented
- рабочий сервер для хранения данных
- протокол gRPC+TLS
- база Postgres и миграции через Goose
- отдельные Auth и Keeper GRPC-подсерверы, чтобы отвязать proto-файлы для возможного масштабирования авторизации
- данные можно : создать, получить, редактировать, удалять, получить все записи юзера, получить все записи определенного типа
- покрыл часть методов юнит-тестами (но не все, по времени не успеваю сделать норм покрытие)
added 10 commits
April 6, 2023 11:24
bambruysk
approved these changes
Apr 19, 2023
Comment on lines
+38
to
+46
| if errors.Is(err, errs.ErrLoginIsEmpty) || | ||
| errors.Is(err, errs.ErrPasswordIsEmpty) || | ||
| errors.Is(err, errs.ErrInvalidLoginOrPassword) { | ||
| return nil, status.Error(codes.InvalidArgument, err.Error()) | ||
| } else if errors.Is(err, errs.ErrLoginAlreadyExist) { | ||
| return nil, status.Error(codes.AlreadyExists, err.Error()) | ||
| } else { | ||
| return nil, status.Error(codes.Internal, "internal problem") | ||
| } |
| return nil, status.Error(codes.Internal, "internal problem") | ||
| } | ||
| } | ||
| if err != nil { |
Comment on lines
+4
to
+12
| "ShamanEstBanan-GophKeeper-server/internal/domain/entity" | ||
| "ShamanEstBanan-GophKeeper-server/internal/errs" | ||
| pb "ShamanEstBanan-GophKeeper-server/internal/proto" | ||
| mainService "ShamanEstBanan-GophKeeper-server/internal/server/authServer/mock" | ||
| "context" | ||
| "errors" | ||
| "github.com/golang/mock/gomock" | ||
| "reflect" | ||
| "testing" |
internal/server/record_test.go
Outdated
| // UnimplementedKeeperServiceServer pb.UnimplementedKeeperServiceServer | ||
| // } | ||
| // type args struct { | ||
| // ctx context.Context |
There was a problem hiding this comment.
Не надо коммитить закомментированный код
Comment on lines
+74
to
+75
| switch e := err.(type) { | ||
| case *pgconn.PgError: |
Comment on lines
+1
to
+23
| syntax = "proto3"; | ||
|
|
||
| package gophKeeper.proto; | ||
|
|
||
| option go_package = "./"; | ||
|
|
||
| message GetAllRecordsRequest{ | ||
| } | ||
|
|
||
| message GetAllRecordsResponse{ | ||
| message Record{ | ||
| string id = 1; | ||
| string name = 2; | ||
| string type = 3; | ||
| } | ||
| repeated Record records = 1; | ||
| } | ||
|
|
||
| message GetRecordsByTypeRequest{ | ||
| string type = 1; | ||
| } | ||
|
|
||
| message GetRecordsByTypeResponse{ |
added 2 commits
April 20, 2023 18:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.