Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/update - Prep next update #4

Merged
merged 9 commits into from
Jan 20, 2025
Merged

Dev/update - Prep next update #4

merged 9 commits into from
Jan 20, 2025

Conversation

ShaneBeee
Copy link
Owner

@ShaneBeee ShaneBeee commented Dec 8, 2024

This PR is a prep for the next update

Temp changelog:

CHANGED:

  • ModEntityType now supports using keys without special characters (ie: colon/slash/underscore)
  • Dynamically added ItemTypes will also support keys without special characters
  • Filter out Skript's alias loading errors for modded items (see [BUG] Every single mod id is not valid #3)
  • Add some debug messages for when modded Items/EntityTypes are registered
    These messages will only be shown when -Dskarclight.debug=true is added to your server's startup script
  • Added java 11 support

@ElgerElg
Copy link

What about add support to mod sounds?
image

@ShaneBeee
Copy link
Owner Author

ShaneBeee commented Dec 14, 2024

What about add support to mod sounds?

Skript should natively support playing sound on a modded server.
Unfortunately there is a bug in Skript which causes it to error out.
I just tested this on Mohist with the TFC mod, and got the big error.
I have reported said issue to Skript:
SkriptLang/Skript#7261

While I could technically add another effect just to play sounds on a modded server...
its a big effect and I think Skript should first attempt to fix their side.

UPDATE:
My PR was merged
SkriptLang/Skript#7271
This fix will be in Skript 2.10

@ShaneBeee ShaneBeee merged commit f99c067 into master Jan 20, 2025
2 checks passed
@ShaneBeee ShaneBeee deleted the dev/update branch January 20, 2025 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants