Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(shannon): selective-offload-est-query-cost #306

Merged
merged 1 commit into from
Dec 31, 2024
Merged

feat(shannon): selective-offload-est-query-cost #306

merged 1 commit into from
Dec 31, 2024

Conversation

RingsC
Copy link
Contributor

@RingsC RingsC commented Dec 29, 2024 •
edited by ShannonBase
Loading

I hereby agree to the terms of the CLA available at: http://www.shannondata.ai/doc/cla/

Summary

impl of estimating query cost of selective-offload .

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

ShannonBase
ShannonBase approved these changes Dec 29, 2024
View reviewed changes
Copy link
Contributor

@ShannonBase ShannonBase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShannonBase ShannonBase self-assigned this Dec 29, 2024
@RingsC RingsC force-pushed the selective-offload-est-query-cost branch 7 times, most recently from be10af7 to e980e46 Compare December 31, 2024 04:52
@RingsC RingsC force-pushed the selective-offload-est-query-cost branch from e980e46 to 8972b02 Compare December 31, 2024 09:01
@ShannonBase ShannonBase merged commit cfa6002 into Shannon-Data:develop Dec 31, 2024
3 checks passed
@RingsC RingsC deleted the selective-offload-est-query-cost branch December 31, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShannonBase ShannonBase ShannonBase approved these changes

Assignees

@ShannonBase ShannonBase

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RingsC @ShannonBase