Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perf: Improving async/await usages #561

Merged
merged 37 commits into from
Jun 15, 2024
Merged

Perf: Improving async/await usages #561

merged 37 commits into from
Jun 15, 2024

Conversation

henriqueholtz
Copy link
Member

@henriqueholtz henriqueholtz commented Jun 13, 2024 •
edited
Loading

The changes are made based on .NET AsyncGuidance.

  • async/await improvements
  • Got rid a lot of synchronous flows
  • Included some new unit tests
  • Adding a postman collection to easily test the new version (that needs some manual steps for now, and have a lot of things to improve. Maybe soon can be a github action). Additional informations on README
  • Fixing a bug when searching something in the home page (is already in the postman collection. Which means run the collection before the merge will fail the request, after the merge all will be passing)
    image

@henriqueholtz
perf: IBooksEmailService. IBookService => Turning some methods as async
8d6986f
@henriqueholtz
perf: Turning a lot of methods as async (IBookService, IBookUserServi…
0740808 
…ce, ILgpdService, IUserService) and its endpoints
@henriqueholtz
chore: IRepositoryGeneric => Remove sync methods without any usage
a584a99
@henriqueholtz
perf: IUserService => Turning method "GenerateHashCodePasswordAndSend…
1ccb4c1 
…EmailToUser" as async
@henriqueholtz
chore: IUserService.UpdateAsync => Adding new keyword to get rid the …
b2eccd5 
…warning
@henriqueholtz
perf: Turning some methods as async in IBookService, IBookUserService…
19907e3 
…, IUserService
@henriqueholtz
perf: IUserService => Turning methods "GetStats" and "ParentAproval" …
2a3f9d2 
…as async and its endpoints
@henriqueholtz
perf: Turning the method "IUserEmailService.SendEmailParentAprovedNot…
34aaec0 
…ifyUser" as async
@henriqueholtz
perf: IUserEmailService && IUserService => Turning methods as async
993433b
@henriqueholtz
perf: Turning "IUserEmailService.SendEmailAnonymizeNotifyAdms" as async
586f7ec
@henriqueholtz
chore: Removing unused method "IBaseService.Get" ("PagedList<TEntity>…
c57186b 
… Get<TKey>(Expression<Func<TEntity, TKey>> order, int page, int itemsPerPage);")
@henriqueholtz
chore: IBaseService => Removing unused and syncronous methods
13e8e74
@henriqueholtz
perf: Migrating the method "IBaseService.Any" to async
2313ea5
@henriqueholtz
chore: Renaming methods adding the suffix "Async" for async methods
42b2565
@henriqueholtz
chore: IRepositoryGeneric => Got rid some unused syncronous methods
37f4d46
@henriqueholtz
perf: IUnitOfWork => Turning all methods as async
e264702
@henriqueholtz
perf: RemovingIRepositoryGeneric.Update to the async version
4c36532
@henriqueholtz
perf: Migrating all usages of "IRepositoryGeneric.Insert" from syncro…
88610e5 
…nous to async and removing it
@henriqueholtz
perf: ("IBaseService", "IRepositoryGeneric", "IBaseService") Migratin…
85a0c81 
…g all methods "Get" to the async version
@henriqueholtz
perf: IBaseService.Find => Migrate to async
f3eeaa7
@henriqueholtz
perf: Migrating "IRepositoryGeneric.Find" to async (includes migratin…
97bd184 
…g "IUserService.ConfirmHashCodePassword" to async)
@henriqueholtz
perf: IBookUserService => Migrating methods "GetGranteeUsersByBookId"…
11816c4 
… and "GetRequestersList" to async including its usages
@henriqueholtz
chore: "BookUserService.CancelAsync" => Removing additional and unuse…
2b69228 
…d call
@henriqueholtz
perf: EmailService => Improving async/await usages
a60c8fa
@henriqueholtz
perf: MuambatorService.AddPackageToTrackerAsync => Using async/await …
ee11839 
…instead of "GetAwaiter().GetResult()"
@henriqueholtz
perf: IUserService => Turning methods "ValidOldPasswordAndChangeUserP…
e8cb7ef 
…assword" and "ChangeUserPassword" as async and its usages
@henriqueholtz
perf: IBookService => Migrating 4 methods to async and its usages/end…
003189c 
…points
@henriqueholtz
perf: IBookService.GetBookWithAllUsersAsync => Using "FirstOrDefaultA…
58cc618 
…sync" directly without getting the list and then FirstOrDefault
@henriqueholtz
perf: BookUserEmailService => Got rid the latest ".Wait()" usages
ca163a4
@henriqueholtz
perf: IPushNotificationService => Turning all 3 methods as async
b03f467
@AppVeyorBot
Copy link

✅ Build Sharebook-Backend: PR Check 1.0.93-gbnaexlv completed (commit 2424ba15f6 by @henriqueholtz)

@AppVeyorBot
Copy link

✅ Build Sharebook-Backend: PR Check 1.0.93-gbfgckxc completed (commit 14ed57baca by @henriqueholtz)

@AppVeyorBot
Copy link

✅ Build Sharebook-Backend: PR Check 1.0.93-mocsinxm completed (commit 2b0dce87b2 by @henriqueholtz)

@AppVeyorBot
Copy link

✅ Build Sharebook-Backend: PR Check 1.0.93-xnpeqfkm completed (commit f7f698edc5 by @henriqueholtz)

@henriqueholtz
fix: UnitOfWork => Avoiding exception when is called "DisposeAsync"
19386b0
@henriqueholtz
fix: MeetupService.SearchAsync => Removing "StringComparison" to avoi…
2b386cd 
…d the following error : "comparisonType: InvariantCultureIgnoreCase))' could not be translated. Additional information: Translation of method 'string.Contains' failed"
@henriqueholtz
feat: Adding postman collection ready to execute against development …
e3c4952 
…environment + infos about in the README
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
10.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@AppVeyorBot
Copy link

✅ Build Sharebook-Backend: PR Check 1.0.93-uohquwfr completed (commit 96bcff3c27 by @henriqueholtz)

@henriqueholtz henriqueholtz changed the title [WIP] Perf: Improving async/await usages Perf: Improving async/await usages Jun 15, 2024
@henriqueholtz henriqueholtz marked this pull request as ready for review June 15, 2024 12:55
@raffacabofrio raffacabofrio merged commit 24ca929 into SharebookBR:develop Jun 15, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raffacabofrio raffacabofrio raffacabofrio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henriqueholtz @AppVeyorBot @raffacabofrio