Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/improve 404 handling #1433

Merged
merged 36 commits into from
Dec 2, 2024
Merged

Feature/improve 404 handling #1433

merged 36 commits into from
Dec 2, 2024

Conversation

rockingrohit9639
Copy link
Contributor

Issue - #1427

DonKoko
DonKoko requested changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@DonKoko DonKoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments

app/components/errors/special-error-handler.tsx Outdated Show resolved Hide resolved
app/components/errors/special-error-handler.tsx Outdated Show resolved Hide resolved
app/components/errors/special-error-handler.tsx Outdated Show resolved Hide resolved
app/components/errors/utils.ts Outdated Show resolved Hide resolved
app/modules/asset/service.server.ts Outdated Show resolved Hide resolved
app/modules/asset/service.server.ts Outdated Show resolved Hide resolved
app/modules/asset/service.server.ts Outdated Show resolved Hide resolved
app/modules/asset/service.server.ts Outdated Show resolved Hide resolved
DonKoko
DonKoko requested changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@DonKoko DonKoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments

app/components/errors/index.tsx Outdated Show resolved Hide resolved
app/components/errors/index.tsx Outdated Show resolved Hide resolved
app/modules/asset/service.server.ts Show resolved Hide resolved
app/components/errors/utils.ts Outdated Show resolved Hide resolved
app/components/errors/special-error-handler.tsx Outdated Show resolved Hide resolved
app/components/errors/special-error-handler.tsx Outdated Show resolved Hide resolved
app/components/errors/special-error-handler.tsx Outdated Show resolved Hide resolved
app/components/errors/special-error-handler.tsx Outdated Show resolved Hide resolved
app/routes/api+/asset.scan.ts Outdated Show resolved Hide resolved
app/routes/api+/user.change-current-organization.ts Outdated Show resolved Hide resolved
DonKoko
DonKoko requested changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@DonKoko DonKoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added 1 comment. Once we resolve this we can do the next model. I would say we can do Kit & Qr. Qr is a bit more tricky as we have to handle the whole process of scanning.

app/routes/api+/user.change-current-organization.ts Show resolved Hide resolved
@DonKoko DonKoko force-pushed the feature/improve-404-handling branch from 5ec5d9e to bcea05b Compare November 27, 2024 15:44
DonKoko
DonKoko requested changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@DonKoko DonKoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments. There is one case we dont need to handle + a bug.

app/components/errors/error-404-handler.tsx Show resolved Hide resolved
app/modules/booking/service.server.ts Show resolved Hide resolved
app/routes/_layout+/bookings.$bookingId.add-assets.tsx Show resolved Hide resolved
app/routes/_layout+/bookings.$bookingId.add-kits.tsx Show resolved Hide resolved
app/routes/_layout+/bookings.$bookingId.cal[.ics].ts Outdated Show resolved Hide resolved
@DonKoko
Copy link
Contributor

DonKoko commented Nov 28, 2024

Also 1 more thing. Add ErrorBoundary to locations.tsx

DonKoko
DonKoko approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@DonKoko DonKoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Great PR. Thanks Rohit

@DonKoko DonKoko merged commit f2f1669 into Shelf-nu:main Dec 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonKoko DonKoko DonKoko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rockingrohit9639 @DonKoko