Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: group required and optional #1453

Merged
merged 12 commits into from
Nov 26, 2024
Merged

feat: group required and optional #1453

merged 12 commits into from
Nov 26, 2024

Conversation

Bhavyajain21
Copy link
Contributor

/fixes #1447
/claim #1447

@algora-pbc algora-pbc bot mentioned this pull request Nov 26, 2024
Closed
@Bhavyajain21 Bhavyajain21 changed the title group required and optional feat: group required and optional Nov 26, 2024
@vikashsprem vikashsprem mentioned this pull request Nov 26, 2024
Closed
@Bhavyajain21
Copy link
Contributor Author

image

@Bhavyajain21
Copy link
Contributor Author

PLEASE review @carlosvirreira / @DonKoko

DonKoko
DonKoko requested changes Nov 26, 2024
View reviewed changes
app/components/assets/custom-fields-inputs.tsx Outdated Show resolved Hide resolved
app/components/assets/custom-fields-inputs.tsx Outdated Show resolved Hide resolved
app/components/assets/custom-fields-inputs.tsx Outdated Show resolved Hide resolved
@Bhavyajain21 Bhavyajain21 requested a review from DonKoko November 26, 2024 13:22
@DonKoko DonKoko merged commit ca0fe34 into Shelf-nu:main Nov 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonKoko DonKoko DonKoko approved these changes

Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature request]: Form Asset Create / Edit - Updated Behaviour
2 participants
@Bhavyajain21 @DonKoko