Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/select all on manage assets #1489

Merged

Conversation

rockingrohit9639
Copy link
Contributor

I have temporarily placed the Select All button at the bottom-left of the modal. Please let me know where should I place it.

Issue - #1450

Copy link
Contributor

@DonKoko DonKoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found 2 small things. Can you check them and then I can deploy for Carlos to also test.

Copy link
Contributor

@DonKoko DonKoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a small issue:
Screenshot 2024-12-13 at 16 26 41

When i click select the value of the tab updates, but it only considers first page. The other places shows it correctly. You can see it says 56 assets selected on the bottom but on the top it says 23.

Copy link
Contributor

@DonKoko DonKoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man, i am sorry i found another issue i didnt notice before.
So here is the deal:

  1. Open manage assets for a booking that already has assets inside it
  2. Click select all
  3. Click clear all
  4. See issue - the selected assets number stays the at the initial number and it should be 0

@DonKoko DonKoko merged commit a0763bc into Shelf-nu:main Dec 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants