Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(custodian-filter): fix issue with Apply Filter button #1515

Closed

Conversation

rockingrohit9639
Copy link
Contributor

Issue - #1513

@DonKoko
Copy link
Contributor

DonKoko commented Dec 13, 2024

Hey @rockingrohit9639. This works but doesn't handle the UX like we want it. Also this happens when the custody field is the first column. Its basically a bug related to which is your first column, so if we do this approach we have to handle each field separately.
I will close this PR as I came up with another approach that i think is better. I will just make sure to disable the operator selector and the value field, if the field selector has no column selected.

@DonKoko DonKoko closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants