Add ability to query for active articles via NewsArticle model #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardxia
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Nice job on this, this LGTM!
FYI, @schroerbrian, @lgarofalo, @jjfreund, the next time we deploy, we'll need to deploy both this and the associated PR, ShelterTechSF/askdarcel-web#1319, at the same time, since this one changes the default behavior of the /news_articles index endpoint to return all articles, not just the active one. I think this is the right change to make, as opposed to trying to do it in a backwards-compatible way, but we just have to deploy both at the same time.
|
BTW, you're failing the lint checks, so you should fix them up. It looks like the failures are autofixable, so if you just run |
…eating a new user
…and create user endpoints to user controller
…ser. Ensure auth0 userId returned from validation hit matches user id sent from front-end
…me fairly complicated integration with auth0 environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are needed for this Breaking News Edit Page UI enhancements.