Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1274 intimate partner violence #1310

Merged
merged 22 commits into from
Mar 1, 2024
Merged

Conversation

schroerbrian
Copy link
Contributor

As discussed with @richardxia , I'm putting this PR up now to allow him to get a head start on reviewing. I don't expect any significant changes from here on out. I will merge and deploy this once UCSF signs off on our current content strategy. The code however will likely stay the same. The Intimate Partner PDF Page is generally similar to our ServicePDFPage; however there are some slight differences due to the different design of the PDF. I've merged this branch into QA-One and deployed the latest there, so you can check the code at https://qaone.sfserviceguide.org/

Brian Schroer added 16 commits July 12, 2023 14:34
…Violence handouts for patient discretion. Tweak PDF styles and content to provide more room on single page
… and alphabetize. Add optional disableGeoLocation prop to category constants
Copy link
Member

@richardxia richardxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, and sorry for taking so long to review it!

For full disclosure, I didn't really read the React code for the actual PDF page, but I'm going to trust that you did the right thing, especially since we already had the other one that I assume you based this one off of.

@schroerbrian
Copy link
Contributor Author

This LGTM, and sorry for taking so long to review it!

For full disclosure, I didn't really read the React code for the actual PDF page, but I'm going to trust that you did the right thing, especially since we already had the other one that I assume you based this one off of.

Thanks for reviewing this! I'm going to wait until UCSF gives us final sign-off before merging this in. As a preventative measure, I will change this PR to a draft so that no one inadvertently merges it in.

@schroerbrian schroerbrian marked this pull request as draft December 6, 2023 22:59
schroerbrian and others added 4 commits December 11, 2023 14:25
* Sort Intimate Partner Violence results by 24/7 availability. Misc code refactors

* A few small changes

* Remove comment

* PR fix

---------

Co-authored-by: Brian Schroer <[email protected]>
* Remove unused eligibility tags from IPV flow

* 1274 Add logic to sort sidebar algolia subcategory refinements by the order received from the API

---------

Co-authored-by: Brian Schroer <[email protected]>
@schroerbrian schroerbrian marked this pull request as ready for review February 27, 2024 18:52
@schroerbrian schroerbrian merged commit 5fcffc8 into master Mar 1, 2024
5 checks passed
@schroerbrian schroerbrian deleted the 1274-intimate-partner-violence branch March 1, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants