-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1274 intimate partner violence #1310
Conversation
… into 1274-intimate-partner-violence
… into 1274-intimate-partner-violence
…isplay it or the generic service handout
… into 1274-intimate-partner-violence
…n instead of long description
… into 1274-intimate-partner-violence
…ay all desired labels on the sidebar
…Violence handouts for patient discretion. Tweak PDF styles and content to provide more room on single page
… and alphabetize. Add optional disableGeoLocation prop to category constants
1346819
to
bbda01c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, and sorry for taking so long to review it!
For full disclosure, I didn't really read the React code for the actual PDF page, but I'm going to trust that you did the right thing, especially since we already had the other one that I assume you based this one off of.
Thanks for reviewing this! I'm going to wait until UCSF gives us final sign-off before merging this in. As a preventative measure, I will change this PR to a draft so that no one inadvertently merges it in. |
Co-authored-by: Brian Schroer <[email protected]>
* Sort Intimate Partner Violence results by 24/7 availability. Misc code refactors * A few small changes * Remove comment * PR fix --------- Co-authored-by: Brian Schroer <[email protected]>
* Remove unused eligibility tags from IPV flow * 1274 Add logic to sort sidebar algolia subcategory refinements by the order received from the API --------- Co-authored-by: Brian Schroer <[email protected]>
As discussed with @richardxia , I'm putting this PR up now to allow him to get a head start on reviewing. I don't expect any significant changes from here on out. I will merge and deploy this once UCSF signs off on our current content strategy. The code however will likely stay the same. The Intimate Partner PDF Page is generally similar to our ServicePDFPage; however there are some slight differences due to the different design of the PDF. I've merged this branch into QA-One and deployed the latest there, so you can check the code at https://qaone.sfserviceguide.org/