Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit Page Enhancements #1319
Edit Page Enhancements #1319
Changes from 5 commits
116db40
ceaa76b
317b817
d8bfded
57cfd76
d142a98
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 26 in app/pages/EditBreakingNewsPage.tsx
GitHub Actions / lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this actually work? Even if it does, I don't think we should be trying to access the props on a nested React component like this. Instead, I'd factor this out into two separate pieces: 1) a pure function that just returns a status string, and 2) a React component that renders the badge icon.
Check failure on line 27 in app/pages/EditBreakingNewsPage.tsx
GitHub Actions / lint
Check failure on line 29 in app/pages/EditBreakingNewsPage.tsx
GitHub Actions / lint
Check failure on line 29 in app/pages/EditBreakingNewsPage.tsx
GitHub Actions / lint
Check failure on line 32 in app/pages/EditBreakingNewsPage.tsx
GitHub Actions / lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related to my other comment, to turn this into a true React component, change the argument from just a plain article to an an object with an
article
property. Also, the convention for React components is to capitalize the first letter of the name, since React components were originally written only as classes, before they added function-based components.(The return type can usually be omitted from React components as well)
Check failure on line 66 in app/pages/EditBreakingNewsPage.tsx
GitHub Actions / lint
Check failure on line 75 in app/pages/EditBreakingNewsPage.tsx
GitHub Actions / lint
Check warning on line 91 in app/pages/EditBreakingNewsPage.tsx
GitHub Actions / lint
Check warning on line 94 in app/pages/EditBreakingNewsPage.tsx
GitHub Actions / lint
Check warning on line 99 in app/pages/EditBreakingNewsPage.tsx
GitHub Actions / lint