Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use v2 API route for GET services by ID #1327

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Conversation

lgarofalo
Copy link
Member

This would flip all GET services by ID to use Go server.

Will discuss with team before any action on this.

@lgarofalo
Copy link
Member Author

I will have to update this to use the Go API server as well in the test build now

@lgarofalo lgarofalo force-pushed the leland/services-by-id-go branch 2 times, most recently from bf66bf2 to e0959d0 Compare March 14, 2024 00:46
@lgarofalo lgarofalo force-pushed the leland/services-by-id-go branch 8 times, most recently from 42a45a8 to 66790f0 Compare March 21, 2024 07:25
Copy link
Contributor

@schroerbrian schroerbrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Just to confirm, PUTs and DELETEs will still be handled by Rails?

@lgarofalo lgarofalo merged commit fd22139 into master Mar 22, 2024
5 checks passed
@lgarofalo lgarofalo deleted the leland/services-by-id-go branch March 22, 2024 02:57
@lgarofalo
Copy link
Member Author

@schroerbrian yea, the only routes of concern for that is the services/id/change_request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants