Fix outdated names in refinement mappings. #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The refinement mappings are a hardcoded list of eligibility and category names used for the left sidebar filters on the search results page (but not the tile results page). This list has been neglected, and various eligibilities and categories have been renamed or deleted from the database. This commit updates the names based on feedback and advice from the Content team, even though some of these even predate the Content team.
richardxia
requested review from
jjfreund,
schroerbrian,
lgarofalo and
katerina-kossler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refinement mappings are a hardcoded list of eligibility and category names used for the left sidebar filters on the search results page (but not the tile results page). This list has been neglected, and various eligibilities and categories have been renamed or deleted from the database. This commit updates the names based on feedback and advice from the Content team, even though some of these even predate the Content team.
I validated these changes by copying and pasting these hashes/objects/maps into the Rails console and double checking that all of these correspond to an Eligibility/Category with the exact same spelling.
This is also somewhat validated by the search results page actually allowing all of these checkboxes to be checked, since the widget normally disables a checkbox if there are no results under that eligibility, and now, with simple search queries like "food", all the eligibility checkboxes are enabled.