Refresh BookmarksMenu when it is opened. #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without adding this logic, the BookmarksMenu will not reflect any new bookmarks that are added unless you refresh the browser. The reason is because the menu is always mounted, as it lives at the `App` layer, though hidden off screen. This means that the `useEffect()` call only happens once, when the app is first loaded. By capturing the `isOpen` variable in the `useEffect()`'s dependency list, we can retrigger the `useEffect()` call whenever the menu is opened, causing it to be updated with the latest state of the user's bookmarks.
richardxia
requested review from
jjfreund,
schroerbrian,
lgarofalo and
katerina-kossler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without adding this logic, the BookmarksMenu will not reflect any new bookmarks that are added unless you refresh the browser. The reason is because the menu is always mounted, as it lives at the
Applayer, though hidden off screen. This means that theuseEffect()call only happens once, when the app is first loaded.By capturing the
isOpenvariable in theuseEffect()'s dependency list, we can retrigger theuseEffect()call whenever the menu is opened, causing it to be updated with the latest state of the user's bookmarks.I missed this during local development, since prior to me moving the dashboard page to the
/route, I had to manually type in the URL of the dashboard page to get back there. This effectively forced a page refresh, causing the app to be loaded from scratch, and the BookmarksMenu receiving the latest bookmarks state. Thankfully, I caught this when doing final testing after deploying to prod. I'm going to deploy this as soon as this passes CI.