Add saved searches APIs. #121
Conversation
richardxia
requested review from
lgarofalo,
jjfreund,
schroerbrian and
waynekoepcke
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -6,7 +6,7 @@ import ( | |||
| "fmt" | |||
| "log" | |||
|
|
|||
| _ "github.com/lib/pq" | |||
There was a problem hiding this comment.
is this bc we didn't want to connect things before?
There was a problem hiding this comment.
To be honest, I don't actually know what this syntax means in Go. I'm calling some methods from the pq package now, since that appeared to be necessary in order to put an array value in a prepared SQL statement, and when I attempted to call that method, my editor provided an autofix suggestion to import this package under its default name of pq.
There was a problem hiding this comment.
If you don't need to explicitly interact with anything from the package you can alias it as _, if you are calling methods there then you can alias it or just remove that _
| WHERE e.id = ANY ($1) | ||
| ` | ||
|
|
||
| const eligibilitiesByNamesSql = ` |
There was a problem hiding this comment.
ya definitely should move away from this later
| } | ||
|
|
||
| // Return the elements of a that are not in b | ||
| func diffStringSlices(a []string, b []string) []string { |
There was a problem hiding this comment.
maybe not-"go like" but feels like we would want to eventually make a shared_logic with a manager for something like this?? or like this would be built-in with soemthing?
There was a problem hiding this comment.
We can move this to a common utility file, theres also a slice.Contains function that might make this easier https://pkg.go.dev/slices
|
For correctness of code, I'd suggesting adding to the integration tests but otherwise seems ok |
This implements the list, get, post, and delete routes. It omits the put route for now, since we might not actually need it yet, and it will probably require some significant refactoring.
This both performs an actual early exit as well as correctly reports a 4xx error rather than a 5xx error if the client submits data in the wrong format.
richardxia
force-pushed
the
58-saved-searches
branch
from
3ad5979
to
04d080f
Compare
|
Improved some minor error handling in 04d080f, since it was helpful as I was debugging the integration with the frontend in ShelterTechSF/askdarcel-web#1368. I think I'm going to merge both of these PRs as soon as they pass CI. Thanks for the review, and sorry to not add the integration tests, but it's something I can do after the initial launch! |
This implements the list, get, post, and delete routes. It omits the put route for now, since we might not actually need it yet, and it will probably require some significant refactoring.
This one's a bit more complicated than the others, since we have a JSONB column for the search query information. On the API side, we want the frontend to be able to send eligibilities and categories by their names, but on the DB side, we want to save them as their integers IDs. In hindsight, maybe we should've just modeled the stuff in JSONB column in a normal, relational way, where the saved search API could return the entire eligibility object instead of its name.
We don't have time to change this before launch, but it might be a good post-launch tech debt payoff project.