Fixed error handling for bookmarks manager #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjfreund
requested review from
lgarofalo,
richardxia,
schroerbrian and
waynekoepcke
as code owners
lgarofalo
reviewed
Aug 29, 2024
internal/bookmarks/manager.go
Outdated
| iUserId, _ := strconv.Atoi(userId) | ||
| dbBookmarks = m.DbClient.GetBookmarksByUserID(iUserId) | ||
| iUserId, err := strconv.Atoi(userId) | ||
| if (err != nil) { |
There was a problem hiding this comment.
dont need to wrap this, normal to just do
if err != nil {
stuff;
}
lgarofalo
reviewed
Aug 29, 2024
internal/bookmarks/manager.go
Outdated
| iUserId, err := strconv.Atoi(userId) | ||
| if (err != nil) { | ||
| log.Printf("%v", err) | ||
| writeStatus(w, http.StatusBadRequest) |
There was a problem hiding this comment.
This is a case where we can update the flow to provide an error message json body response
lgarofalo
reviewed
Aug 29, 2024
internal/bookmarks/manager.go
Outdated
| } | ||
|
|
||
| dbBookmark := m.DbClient.GetBookmarkByID(id) | ||
| dbBookmark, err := m.DbClient.GetBookmarkByID(id) | ||
| if (err != nil) { |
There was a problem hiding this comment.
We want to log the error here too, just the same flow as other cases
lgarofalo
reviewed
Aug 29, 2024
internal/bookmarks/manager.go
Outdated
| iUserId, err := strconv.Atoi(userId) | ||
| if (err != nil) { | ||
| log.Printf("%v", err) | ||
| writeStatus(w, http.StatusBadRequest) |
There was a problem hiding this comment.
I can add a test for any 400 cases
lgarofalo
reviewed
Aug 29, 2024
internal/db/manager.go
Outdated
There was a problem hiding this comment.
makes sense, we do want to bubble up errors, it was a mistake of me to not do that originally
|
Updated PR with responses to my comments |
richardxia
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
This LGTM, and thanks, @lgarofalo, for pushing up a commit to create a common Error struct for returning error responses with JSON bodies!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.