Remove usage of JsBuffer::external as it isn't supported in Electron.

ShieldBattery · Jan 16, 2024 · 0a0fed9 · 0a0fed9
1 parent 77f5c19
commit 0a0fed9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/release_package.yml b/.github/workflows/release_package.yml
@@ -42,7 +42,7 @@ jobs:
           NEW_VERSION: ${{ github.event.inputs.release-version }}
 
       - name: Compile .node
-        run: pnpm run build-debug
+        run: pnpm run build-release
 
       - name: Sign binary
         env:

diff --git a/native/src/lib.rs b/native/src/lib.rs
@@ -129,8 +129,10 @@ impl RegistryThread {
                     Data::U32(n) => Ok(cx.number(n as f64).upcast()),
                     Data::U64(n) => Ok(cx.number(n as f64).upcast()),
                     Data::Binary(b) => {
-                        let typed_array = JsBuffer::external(&mut cx, b);
-                        Ok(typed_array.upcast())
+                        let mut buffer = JsBuffer::new(&mut cx, b.len())?;
+                        let buffer_data = buffer.as_mut_slice(&mut cx);
+                        buffer_data.copy_from_slice(&b);
+                        Ok(buffer.upcast())
                     }
                     t => cx.throw_error(format!("Unsupported registry type: {}", t)),
                 },