fix: unit test of userService

ShiinaKin · Sep 27, 2024 · 593ad8b · 593ad8b
1 parent 06ceffa
commit 593ad8b
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/app/src/main/kotlin/io/sakurasou/service/user/UserServiceImpl.kt b/app/src/main/kotlin/io/sakurasou/service/user/UserServiceImpl.kt
@@ -158,8 +158,13 @@ class UserServiceImpl(
             )
 
             val isModifyGroup = patchRequest.groupId != null
+            val isModifyDefaultAlbum = patchRequest.defaultAlbumId != null
 
             runCatching {
+                if (isModifyDefaultAlbum) {
+                    val album = albumDao.findAlbumById(userUpdateDTO.defaultAlbumId!!) ?: throw AlbumNotFoundException()
+                    if (album.userId != id) throw WrongParameterException("Album not belong to user")
+                }
                 val influenceRowCnt = userDao.updateUserById(userUpdateDTO)
                 if (influenceRowCnt < 1) throw UserNotFoundException()
                 if (isModifyGroup) imageDao.updateImageGroupIdByUserId(id, userUpdateDTO.groupId)

diff --git a/app/src/test/kotlin/io/sakurasou/service/user/UserServiceTest.kt b/app/src/test/kotlin/io/sakurasou/service/user/UserServiceTest.kt
@@ -21,6 +21,7 @@ import io.sakurasou.model.dto.ImageCountAndTotalSizeDTO
 import io.sakurasou.model.dto.UserInsertDTO
 import io.sakurasou.model.dto.UserManageUpdateDTO
 import io.sakurasou.model.dto.UserSelfUpdateDTO
+import io.sakurasou.model.entity.Album
 import io.sakurasou.model.entity.Group
 import io.sakurasou.model.entity.User
 import io.sakurasou.model.setting.SystemSetting
@@ -200,6 +201,7 @@ class UserServiceTest {
     @Test
     fun `deleteUser should delete user successfully when user exists`() = runBlocking {
         val userId = 1L
+        every { imageDao.deleteImageByUserId(userId) } returns 1
         every { userDao.deleteUserById(userId) } returns 1
 
         userService.deleteUser(userId)
@@ -210,6 +212,7 @@ class UserServiceTest {
     @Test
     fun `deleteUser should throw UserDeleteFailedException when user not found`() = runBlocking {
         val userId = 1L
+        every { imageDao.deleteImageByUserId(userId) } returns 1
         every { userDao.deleteUserById(userId) } returns 0
 
         assertFailsWith<UserDeleteFailedException> {
@@ -234,6 +237,14 @@ class UserServiceTest {
             updateTime = now,
             createTime = now
         )
+        val newAlbum = Album(
+            id = 2,
+            name = "newAlbum",
+            userId = userId,
+            createTime = now,
+            imageCount = 1,
+            isUncategorized = false,
+        )
         val patchRequest = UserSelfPatchRequest(
             password = "newPassword",
             email = "[email protected]",
@@ -251,6 +262,7 @@ class UserServiceTest {
             updateTime = now
         )
 
+        every { albumDao.findAlbumById(exceptedUpdateDTO.defaultAlbumId!!) } returns newAlbum
         every { userDao.findUserById(userId) } returns oldUserInfo
         every { BCrypt.withDefaults().hashToString(12, patchRequest.password!!.toCharArray()) } returns encodedPassword
         every { userDao.updateSelfById(exceptedUpdateDTO) } returns 1
@@ -342,6 +354,14 @@ class UserServiceTest {
             updateTime = now,
             createTime = now
         )
+        val newAlbum = Album(
+            id = 2,
+            name = "newAlbum",
+            userId = userId,
+            createTime = now,
+            imageCount = 1,
+            isUncategorized = false,
+        )
         val patchRequest = UserManagePatchRequest(
             groupId = 2,
             password = "newPassword",
@@ -361,6 +381,7 @@ class UserServiceTest {
             updateTime = now
         )
 
+        every { albumDao.findAlbumById(exceptedUpdateDTO.defaultAlbumId!!) } returns newAlbum
         every { userDao.findUserById(userId) } returns oldUserInfo
         every { BCrypt.withDefaults().hashToString(12, patchRequest.password!!.toCharArray()) } returns encodedPassword
         every { userDao.updateUserById(exceptedUpdateDTO) } returns 1