Merge pull request #29 from ZunwDev/development

enhancement(global) few code improvements and fixes
Shiperist · Jun 23, 2023 · 2356b0e · 2356b0e
2 parents 3a1aa0a + 30dff69
commit 2356b0e
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 8 deletions.
diff --git a/dashboard/src/components/Text/Subtitle.tsx b/dashboard/src/components/Text/Subtitle.tsx
@@ -1,6 +1,6 @@
 import React from 'react';
 
-const Subtitle: React.FC<React.HTMLAttributes<HTMLParagraphElement>> = ({
+const Subtitle: React.FC<React.HTMLAttributes<HTMLHeadingElement>> = ({
   className = '',
   children,
   ...other

diff --git a/dashboard/src/components/Text/Title.tsx b/dashboard/src/components/Text/Title.tsx
@@ -1,6 +1,6 @@
 import React from 'react';
 
-const Title: React.FC<React.HTMLAttributes<HTMLParagraphElement>> = ({
+const Title: React.FC<React.HTMLAttributes<HTMLHeadingElement>> = ({
   className = '',
   children,
   ...other

diff --git a/dashboard/src/components/profile/profile-section-content.tsx b/dashboard/src/components/profile/profile-section-content.tsx
@@ -1,7 +1,7 @@
 import React, { useEffect, useState } from 'react';
 import { useSession } from 'next-auth/react';
 import { Text, TextInput } from '@tremor/react';
-import Button from '~/components/Base/Button';
+import Button from '~/components/Button/Button';
 
 const ProfileSectionContent = () => {
   const session = useSession();

diff --git a/dashboard/src/pages/app/[slug].tsx b/dashboard/src/pages/app/[slug].tsx
@@ -18,7 +18,7 @@ const Project: NextPage = () => {
   }
 
   return (
-    <div className="midwrap max-w-full w-[1200px] mx-auto px-4">
+    <div className="midwrap max-w-7xl mx-auto px-4">
       <Text>{data.name}</Text>
     </div>
   );

diff --git a/dashboard/src/pages/app/create/index.tsx b/dashboard/src/pages/app/create/index.tsx
@@ -9,21 +9,22 @@ import { GitProvider } from '~/types/app-types';
 import { AppCreateProviderCard } from '~/components/app/create/app-create-provider-card';
 import TextInput from '~/components/TextInput/TextInput';
 
+const providerClass = 'w-5 h-5 text-ctp-text';
 export const providers: GitProvider[] = [
   {
     key: 'github',
     name: 'GitHub',
-    icon: <Github className="w-5 h-5 text-ctp-text" />
+    icon: <Github className={providerClass} />
   },
   {
     key: 'gitlab',
     name: 'GitLab',
-    icon: <Gitlab className="w-5 h-5 text-ctp-text" />
+    icon: <Gitlab className={providerClass} />
   },
   {
     key: 'bitbucket',
     name: 'Bitbucket',
-    icon: <Github className="w-5 h-5 text-ctp-text" />
+    icon: <Github className={providerClass} />
   }
 ];
 

diff --git a/dashboard/src/pages/profile/[slug]/index.tsx b/dashboard/src/pages/profile/[slug]/index.tsx
@@ -219,7 +219,7 @@ const Profile: NextPage = () => {
   });
 
   return (
-    <div className="midwrap max-w-full w-[1200px] mx-auto px-4">
+    <div className="midwrap max-w-7xl mx-auto px-4">
       <div className="tbwrap py-8 flex flex-row">
         <div className="w-[256px] flex flex-col px-4 gap-2">
           <div className="sticky top-24">