Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataLoader to check for batch size of 1 an ignore #67

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

sreeshnair
Copy link
Contributor

@sreeshnair sreeshnair commented Dec 1, 2021

A batch of size 1 should not be included in the DataLoader. We want to have the DataLoader handle this (but still keep batches of size > 1) and then remove the logic in learner.py that handles skipping batches of size 1.

DataLoader to check for batch size of 1 an ignore

Remove logic to check for batch size of 1 from learner.py

https://shoprunner.atlassian.net/browse/DS-2406

Pull Request Checklist

  • All tests in the tests folder pass with a local build
  • Pull request includes a description of why we are doing this
  • Init files import new capabilities to appropriate level of package (if applicable)
  • CHANGELOG has been updated
  • Version in _version.py has been updated
  • README has been updated (if applicable)
  • requirements.txt and requirements-dev.txt have been recompiled if requirements in setup.py or requirements-dev.in changed.

@sreeshnair sreeshnair requested a review from a team December 1, 2021 14:13
Copy link
Contributor

@mcundiff3 mcundiff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall. I left a comment and we can chat about it but there may not be a solution. I guess we could leave the check in both places.

@sreeshnair sreeshnair requested a review from mcundiff3 January 23, 2022 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants