This repository has been archived by the owner on Jun 13, 2018. It is now read-only.
Re-authenticate with stamps api on two additional faults. #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the Stamps API documentation re-authenticating is also a potential fix for 'Conversation Out-Of-Sync' and 'Invalid Conversation Token' faults. Ref: http://developer.stamps.com/assets/documents/developer/downloads/Stamps.com_SWSIM_Reference_v42.pdf
|
I had to make a change to master that made GitHub automatically close your (and a few other) PR. It was not intentional close, nor in response to its content. Sorry for the inconvenience. |
|
Thanks @maartenvg I will try to monitor this project, and re-base my PR once the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Stamps API documentation re-authenticating is also a potential
fix for 'Conversation Out-Of-Sync' and 'Invalid Conversation Token' faults.
Ref: http://developer.stamps.com/assets/documents/developer/downloads/Stamps.com_SWSIM_Reference_v42.pdf
Note: This is just bringing back #312, but with CI passing. CI was failing on #312 due to bad luck... @kvanwagenen forked the project while it was broken ( 9ac1bb4
fixed the remote test failure)
PR #545 was recently closed by @maartenvg, and I assume that was because PR #545 wasn't a simple 1-commit merge against master. So I have re-based the changes against master, and re-submitted.