Include name in config

Shopify · Oct 1, 2024 · 64fa18e · 64fa18e
1 parent 5d737cc
commit 64fa18e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/app/src/cli/models/extensions/specification.ts b/packages/app/src/cli/models/extensions/specification.ts
@@ -274,7 +274,7 @@ export function createContractBasedModuleSpecification<TConfiguration extends Ba
     deployConfig: async (config, _) => {
       // These are loaded automatically for all modules, but are considered "first class" and not part of extension contracts
       // If a module needs them, they can access them from the manifest.
-      const {type, handle, uid, name, ...configWithoutFirstClassFields} = config
+      const {type, handle, uid, ...configWithoutFirstClassFields} = config
       return configWithoutFirstClassFields
     },
   })

diff --git a/packages/app/src/cli/utilities/json-schema.ts b/packages/app/src/cli/utilities/json-schema.ts
@@ -30,7 +30,7 @@ export async function unifiedConfigurationParserFactory(
 
     // These are loaded automatically for all modules, but are considered "first class" and not part of extension contracts
     // If a module needs them, they can access them from the manifest.
-    const {type, handle, uid, name, ...subjectForAjvWithoutFirstClassFields} = subjectForAjv
+    const {type, handle, uid, ...subjectForAjvWithoutFirstClassFields} = subjectForAjv
     const jsonSchemaParse = jsonSchemaValidate(subjectForAjvWithoutFirstClassFields, contract)
 
     // Finally, we de-duplicate the error set from both validations -- identical messages for identical paths are removed