Merge pull request #4544 from montalvomiguelo/fix-hotreload-sections

Fix hot reload on sections
Shopify · Oct 1, 2024 · cd9c393 · cd9c393
2 parents e0a977f + a2f31c2
commit cd9c393
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/.changeset/smart-islands-learn.md b/.changeset/smart-islands-learn.md
@@ -0,0 +1,5 @@
+---
+'@shopify/theme': patch
+---
+
+Fix hot reload on sections
diff --git a/packages/theme/src/cli/utilities/theme-environment/hot-reload/server.test.ts b/packages/theme/src/cli/utilities/theme-environment/hot-reload/server.test.ts
@@ -128,7 +128,7 @@ describe('hot-reload server', () => {
     const hotReloadEventsLengthBeforeChange = hotReloadEvents.length
     // Since the JSON file was removed, the section file is not referenced anymore:
     await triggerFileEvent('change', testSectionFileKey)
-    expect(hotReloadEvents).toHaveLength(hotReloadEventsLengthBeforeChange)
+    expect(hotReloadEvents.at(-1)).toMatch(`data: {"type":"full","key":"${testSectionFileKey}"}`)
     await nextTick()
 
     // -- Updates section groups:

diff --git a/packages/theme/src/cli/utilities/theme-environment/hot-reload/server.ts b/packages/theme/src/cli/utilities/theme-environment/hot-reload/server.ts
@@ -301,6 +301,8 @@ function hotReloadSections(key: string, ctx: DevServerContext) {
 
   if (sectionsToUpdate.size > 0) {
     emitHotReloadEvent({type: 'section', key, names: [...sectionsToUpdate]})
+  } else {
+    emitHotReloadEvent({type: 'full', key})
   }
 }