[stable] Include theme-check-docs-updater data folder in final bundled dist

.changeset/real-ravens-camp.md

@@ -0,0 +1,5 @@
+---
+'@shopify/theme': patch
+---
+
+Fix theme check failing when there is a network issue

package.json

@@ -112,7 +112,8 @@
       "eslint-plugin-react-hooks",
       "esbuild",
       "@shopify/cli-hydrogen",
-      "@shopify/theme-check-node"
+      "@shopify/theme-check-node",
+      "@shopify/theme-check-docs-updater"
     ],
     "ignoreWorkspaces": [
       "packages/eslint-plugin-cli"

packages/app/package.json

@@ -56,7 +56,7 @@
     "@shopify/plugin-cloudflare": "3.60.0",
     "@shopify/polaris": "12.10.0",
     "@shopify/polaris-icons": "8.0.0",
-    "@shopify/theme-check-node": "2.5.0",
+    "@shopify/theme-check-node": "2.5.1",
     "body-parser": "1.20.2",
     "chokidar": "3.5.3",
     "diff": "5.1.0",

packages/cli/bin/bundle.js

@@ -1,9 +1,9 @@
 /* eslint-disable @shopify/cli/specific-imports-in-bootstrap-code */
 /* eslint-disable import/no-extraneous-dependencies */
-import cleanBundledDependencies from '../../../bin/bundling/clean-bundled-dependencies.js'
 import ShopifyStacktraceyPlugin from '../../../bin/bundling/esbuild-plugin-stacktracey.js'
 import ShopifyVSCodePlugin from '../../../bin/bundling/esbuild-plugin-vscode.js'
 import GraphiQLImportsPlugin from '../../../bin/bundling/esbuild-plugin-graphiql-imports.js'
+import cleanBundledDependencies from '../../../bin/bundling/clean-bundled-dependencies.js'
 import {build as esBuild} from 'esbuild'
 import {copy} from 'esbuild-plugin-copy'
 import glob from 'fast-glob'
@@ -27,6 +27,9 @@ const yogafile = glob.sync('../../node_modules/.pnpm/**/yoga.wasm')[0]
 const themePath = require.resolve('@shopify/theme-check-node')
 const configYmlPath = joinPath(themePath, '..', '..', 'configs/*.yml')
 
+const themeUpdaterPath = require.resolve('@shopify/theme-check-docs-updater')
+const themeUpdaterDataPath = joinPath(themeUpdaterPath, '..', '..', 'data/*')
+
 esBuild({
   bundle: true,
   entryPoints: ['./src/**/*.ts'],
@@ -74,6 +77,10 @@ esBuild({
           from: [configYmlPath],
           to: ['./dist/configs/'],
         },
+        {
+          from: [themeUpdaterDataPath],
+          to: ['./dist/data/'],
+        },
       ],
     }),
   ],

packages/theme/package.json

@@ -42,8 +42,8 @@
   "dependencies": {
     "@oclif/core": "3.26.5",
     "@shopify/cli-kit": "3.60.0",
-    "@shopify/theme-check-node": "2.5.0",
-    "@shopify/theme-language-server-node": "1.11.0",
+    "@shopify/theme-check-node": "2.5.1",
+    "@shopify/theme-language-server-node": "1.11.1",
     "yaml": "2.3.2"
   },
   "devDependencies": {

packages/theme/src/cli/commands/theme/check.ts

@@ -15,7 +15,7 @@ import {
 import ThemeCommand from '../../utilities/theme-command.js'
 import {Flags} from '@oclif/core'
 import {globalFlags} from '@shopify/cli-kit/node/cli'
-import {outputInfo} from '@shopify/cli-kit/node/output'
+import {outputInfo, consoleError} from '@shopify/cli-kit/node/output'
 import {renderInfo, renderSuccess} from '@shopify/cli-kit/node/ui'
 import {themeCheckRun, LegacyIdentifiers} from '@shopify/theme-check-node'
 import {findPathUp} from '@shopify/cli-kit/node/fs'
@@ -133,7 +133,14 @@ export default class Check extends ThemeCommand {
       return
     }
 
-    const {offenses, theme} = await themeCheckRun(path, config)
+    const {offenses, theme} = await themeCheckRun(path, config, (message) => {
+      // We should replace this with outputDebug when it logs to STDERR by default.
+      // We need this right now because the --verbose flags pollutes STDOUT
+      // when used with --output=json with the current outputDebug defaults.
+      if (process.env.SHOPIFY_TMP_FLAG_DEBUG) {
+        consoleError(message)
+      }
+    })
 
     const offensesByFile = sortOffenses(offenses)