-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Themes] - Switch the implementation of theme
commands to run the TypeScript by default
#4439
Conversation
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1860 tests passing in 846 suites. Report generated by 🧪jest coverage report action from 2b06d21 |
theme
commands to run the TypeScript by default
6f1a107
to
db0dff7
Compare
db0dff7
to
8ba0ee7
Compare
8ba0ee7
to
cc2e2d5
Compare
* Add info banner in the new `shopify theme dev` command (mentioning the --legacy flag) * Update docs
cc2e2d5
to
2b06d21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR, @jamesmengo! It looks great! I've made a minor commit to update the documentation and rename the flag to --legacy
;)
WHY are these changes introduced?
Closes https://github.com/Shopify/develop-advanced-edits/issues/316
WHAT is this pull request doing?
Replaces the
dev-preview
flag with an inversestable
flag so that we default to Typescript implementationHow to test your changes?
stable
flagPost-Release Steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist