Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix class name in AssociationError message #557

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Fix class name in AssociationError message #557

merged 1 commit into from
Feb 12, 2024

Conversation

eugeneius
Copy link
Contributor

self is the model here, so self.class is always "Class".

@eugeneius
Fix class name in AssociationError message
223dbb5 
`self` is the model here, so `self.class` is always "Class".
nvasilevski
nvasilevski approved these changes Feb 12, 2024
View reviewed changes
Copy link

@nvasilevski nvasilevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nvasilevski nvasilevski merged commit d1e53f7 into Shopify:main Feb 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvasilevski nvasilevski nvasilevski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eugeneius @nvasilevski