Remove support for deprecated login

Shopify · Jan 5, 2024 · b06c2b5 · b06c2b5
1 parent 957eccd
commit b06c2b5
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 35 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -11,32 +11,14 @@ jobs:
         include:
           - job_name: 'staff store, custom app login'
             store: shimmering-islands.myshopify.com
-            app_id: ''
-            app_password: ''
             access_token: SHOP_ACCESS_TOKEN
             password: ''
 
-          - job_name: 'staff store, private app login'
-            store: shimmering-islands.myshopify.com
-            app_id: SHOP_APP_ID
-            app_password: SHOP_APP_PASSWORD
-            access_token: ''
-            password: ''
-
           - job_name: 'dev store, custom app login'
             store: cpclermont-dev-store.myshopify.com
-            app_id: ''
-            app_password: DEV_APP_PASSWORD
             access_token: DEV_ACCESS_TOKEN
             password: DEV_PASSWORD
 
-          - job_name: 'dev store, private app login'
-            store: cpclermont-dev-store.myshopify.com
-            app_id: DEV_APP_ID
-            app_password: DEV_APP_PASSWORD
-            access_token: ''
-            password: DEV_PASSWORD
-
     name: ${{ matrix.job_name }}
 
     steps:
@@ -50,8 +32,6 @@ jobs:
         uses: ./
         id: lighthouse-ci-action
         with:
-          app_id: ${{ secrets[matrix.app_id] }}
-          app_password: ${{ secrets[matrix.app_password] }}
           access_token: ${{ secrets[matrix.access_token] }}
           store: ${{ matrix.store }}
           password: ${{ secrets[matrix.password] }}

diff --git a/README.md b/README.md
@@ -66,10 +66,3 @@ For the GitHub Status Checks on PR. One of the two arguments is required:
 * `lhci_github_token` - (optional) GitHub personal access token
 
 For more details on the implications of choosing one over the other, refer to the [Lighthouse CI Getting Started Page](https://github.com/GoogleChrome/lighthouse-ci/blob/main/docs/getting-started.md#github-status-checks)
-
-### Deprecated authentication configuration
-
-The following were used to authenticate with private apps.
-
-* `app_id` - (deprecated) Shopify store private app ID.
-* `app_password` - (deprecated) Shopify store private app password.
diff --git a/action.yml b/action.yml
@@ -43,14 +43,6 @@ inputs:
     description: 'Minimum accessibility score'
     required: false
     default: 0.9
-  app_id:
-    description: '(deprecated) Shopify private app ID'
-    depreciationMessage: Shopify private apps are deprecated. Use a Custom App `access_token` instead.
-    required: false
-  app_password:
-    description: '(deprecated) Shopify private app password'
-    depreciationMessage: Shopify private apps are deprecated. Use a Custom App `access_token` instead.
-    required: false
 runs:
   using: 'docker'
   image: 'Dockerfile'