This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Add attachments to extensions #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanBrushett
approved these changes
Jan 25, 2018
|
|
||
| ([normalized_message] + attachment_text).compact.join("\n") | ||
| def parse_attachment(a) |
There was a problem hiding this comment.
⛏ In a perfect world, this would be attachement rather than just a.
There was a problem hiding this comment.
It'll bug me now if I don't fix it - give me a sec
| @@ -118,7 +130,7 @@ def dispatch_message(user) | |||
| source.private_message! if channel && channel[0] == "D" | |||
| message = Message.new(robot, body, source) | |||
| message.command! if source.private_message? | |||
| message.extensions[:slack] = { timestamp: data["ts"] } | |||
| message.extensions[:slack] = { timestamp: data["ts"], attachments: data["attachments"] } | |||
ridwanmsharif
force-pushed
the
add-attachments-to-extensions
branch
from
39aa1b6 to
b0ffefc
Compare
jarthorn
approved these changes
Jan 25, 2018
RyanBrushett
approved these changes
Jan 25, 2018
|
Sure, guys :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypicked and amended styling for commits made for PR litaio#118 in lita-slack that is currently unmaintained. Allowing for attachments being made available in the extensions, would help us address issues we're having with Spy. Review required to see if the changes are appropriate. @Shopify/operational-excellence