Increases zip code padding check to 4 characters for UK addresses #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Apple Pay anonymizes postal codes for British and Canadian addresses until the user has accepted payment. (source)
The mobile-buy-sdk accounts for this by adding padding to British and Canadian postal codes when Apple Pay only shows 3 characters. Some British postal codes have 4 characters, though, causing no padding to be added which causes errors in Apple Pay when attempting to get shipping costs.
An example postal code that causes this is
WC2H 9BHin London. Apple pay will shorten this toWC2H.This change increases the number of characters by 1 to allow these British postal codes to still apply padding.