Update chart dimensions to update on chart height resize

Shopify · Sep 12, 2023 · d551de7 · d551de7
1 parent afa1e1b
commit d551de7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/packages/polaris-viz/CHANGELOG.md b/packages/polaris-viz/CHANGELOG.md
@@ -7,6 +7,8 @@ and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
 <!-- ## Unreleased -->
 
+- Fixed issue where chart would not resize on height change
+
 ## [9.10.7] - 2023-09-06
 
 ### Changed

diff --git a/.../polaris-viz/src/components/ChartContainer/components/ChartDimensions/ChartDimensions.tsx b/.../polaris-viz/src/components/ChartContainer/components/ChartDimensions/ChartDimensions.tsx
@@ -55,7 +55,8 @@ export function ChartDimensions({
 
   const updateDimensions = useCallback(() => {
     if (
-      previousEntry?.contentRect.width === entry?.contentRect.width ||
+      (previousEntry?.contentRect.width === entry?.contentRect.width &&
+        previousEntry?.contentRect.height === entry?.contentRect.height) ||
       entry == null
     ) {
       return;
@@ -65,7 +66,7 @@ export function ChartDimensions({
     const {x, y} = entry.target.getBoundingClientRect();
 
     setChartDimensions({width, height, x, y: y + window.scrollY});
-  }, [entry, previousEntry?.contentRect.width]);
+  }, [entry, previousEntry?.contentRect]);
 
   const debouncedUpdateDimensions = useDebouncedCallback(() => {
     updateDimensions();