Skip to content

Commit

Permalink
Adjust tooltip position on StackedAreaChart when page is scrolled
Browse files Browse the repository at this point in the history
  • Loading branch information
euripidean committed Sep 29, 2023
1 parent 20ba951 commit e2b1793
Show file tree
Hide file tree
Showing 2 changed files with 56 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ import {useStackedData} from './hooks';
import {StackedAreas, Points} from './components';
import {useStackedChartTooltipContent} from './hooks/useStackedChartTooltipContent';
import {yAxisMinMax} from './utilities/yAxisMinMax';
import {getAlteredStackedAreaChartPosition} from './utilities/getAlteredStackedAreaChartPosition';
import styles from './Chart.scss';

const TOOLTIP_POSITION: TooltipPositionOffset = {
Expand Down Expand Up @@ -382,6 +383,7 @@ export function Chart({
focusElementDataType={DataType.Point}
getMarkup={getTooltipMarkup}
getPosition={getTooltipPosition}
getAlteredPosition={getAlteredStackedAreaChartPosition}
id={tooltipId}
margin={ChartMargin}
onIndexChange={(index) => setActivePointIndex(index)}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
import type {Dimensions} from '@shopify/polaris-viz-core';

import type {TooltipPositionOffset} from '../../TooltipWrapper';
import type {Margin} from '../../../types';

// The space between the cursor and the tooltip
const TOOLTIP_MARGIN = 20;

export interface AlteredPositionProps {
bandwidth: number;
chartBounds: {x: number; y: number; width: number; height: number};
currentX: number;
currentY: number;
isPerformanceImpacted: boolean;
margin: Margin;
position: TooltipPositionOffset;
tooltipDimensions: Dimensions;
}

export interface AlteredPositionReturn {
x: number;
y: number;
}

export type AlteredPosition = (
props: AlteredPositionProps,
) => AlteredPositionReturn;

export function getAlteredStackedAreaChartPosition({
currentX,
currentY,
chartBounds,
margin,
tooltipDimensions,
}: AlteredPositionProps): AlteredPositionReturn {
const x = Math.min(
Math.max(currentX, TOOLTIP_MARGIN),
chartBounds.width - tooltipDimensions.width - TOOLTIP_MARGIN,
);

// Y POSITIONING
// If y is below the chart, adjust the tooltip position to the bottom of the chart
//

const y =
currentY >= chartBounds.y + chartBounds.height
? chartBounds.height -
tooltipDimensions.height -
TOOLTIP_MARGIN -
margin.Bottom
: currentY;

return {x, y};
}

0 comments on commit e2b1793

Please sign in to comment.