UX updates for in-context MetricCards #1583
Merged
+27
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susiekims
changed the title
size-limit report 📦
|
envex
reviewed
Sep 5, 2023
packages/polaris-viz/src/components/TrendIndicator/constants.ts
Outdated
Show resolved
Hide resolved
susiekims
force-pushed
the
ux-updates
branch
from
1f90bb8 to
e590d76
Compare
|
Something is funky with the simple bar chart examples: https://shopify.chromatic.com/test?appId=6062ad4a2d14cd0021539c1b&id=64f88b90da3f65699ee66315 
|
susiekims
force-pushed
the
ux-updates
branch
from
8f384cd to
5dbdd0a
Compare
susiekims
force-pushed
the
ux-updates
branch
from
498de25 to
f4eee43
Compare
envex
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Does this close any currently open issues?
Part of https://github.com/Shopify/core-issues/issues/58330
What do the changes look like?
Storybook link
https://6062ad4a2d14cd0021539c1b-rgfylvlouv.chromatic.com/?path=/story/polaris-viz-chromatic-charts-simplebarchart--trend-with-all-positive
Before merging
Check your changes on a variety of browsers and devices.
Update the Changelog's Unreleased section with your changes.
Update relevant documentation, tests, and Storybook.
Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package