Fix issue with bar with when data changes from zero values #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
envex
force-pushed
the
envex/zero-to-data
branch
from
60fcb96 to
55c0f71
Compare
envex
force-pushed
the
envex/zero-to-data
branch
from
55c0f71 to
b8f1ae7
Compare
JeremyLudwigDev
approved these changes
Sep 21, 2023
envex
force-pushed
the
envex/zero-to-data
branch
2 times, most recently
from
d64e414 to
ddfac56
Compare
envex
force-pushed
the
envex/zero-to-data
branch
from
ddfac56 to
b7b2090
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/Shopify/core-issues/issues/60729
Fixes issue when switching between data sets with data and data sets with all 0 values causing the bar width to be too small.
https://6062ad4a2d14cd0021539c1b-ikwtklqeiu.chromatic.com/?path=/story/polaris-viz-charts-barchart-playground--zero-data