Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run chromatic on push now that turbosnap is enabled #1592

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

envex
Copy link
Collaborator

@envex envex commented Sep 26, 2023

Chromatic recommends running on push instead of pull_request and now that we've enabled TurboSnap, we only run tests on files that have changed, not the entire storybook.

@github-actions
Copy link

@github-actions
Copy link

github-actions bot commented Sep 26, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
polaris-viz-core-cjs 61.3 KB (0%) 1.3 s (0%) 1.2 s (-13.91% 🔽) 2.4 s
polaris-viz-cjs 211.02 KB (0%) 4.3 s (0%) 3.7 s (+9.34% 🔺) 7.9 s
polaris-viz-esm 173.4 KB (0%) 3.5 s (0%) 2.7 s (+16.97% 🔺) 6.1 s
polaris-viz-css 4.57 KB (0%) 92 ms (0%) 372 ms (-50.32% 🔽) 464 ms
polaris-viz-esnext 178.51 KB (0%) 3.6 s (0%) 1.4 s (-20.32% 🔽) 5 s

@envex envex force-pushed the envex/chromatic-on-push branch from 03b67de to 74c8dc6 Compare September 26, 2023 14:15
@envex envex merged commit a2f879d into main Sep 26, 2023
6 checks passed
@shopify-shipit shopify-shipit bot temporarily deployed to production September 26, 2023 18:43 Inactive
@envex envex deleted the envex/chromatic-on-push branch September 12, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant