Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed RenderInnerValueContent type to include active index #1597

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

michaelnesen
Copy link
Collaborator

@michaelnesen michaelnesen commented Oct 2, 2023

What does this implement/fix?

This PR changes renderInnerValueContent prop in the DonutChart to pass down the active index

We want to have access to the active index inside the renderInnerValueContent override prop. Context on why we want this change here

Does this close any currently open issues?

What do the changes look like?

Storybook link

http://localhost:6006/?path=/story/polaris-viz-charts-donutchart--custom-inner-value-content

Before merging

  • Check your changes on a variety of browsers and devices.

  • Update the Changelog's Unreleased section with your changes.

  • Update relevant documentation, tests, and Storybook.

  • Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
polaris-viz-core-cjs 61.3 KB (0%) 1.3 s (0%) 1.3 s (-33.77% 🔽) 2.5 s
polaris-viz-cjs 211.02 KB (+0.01% 🔺) 4.3 s (+0.01% 🔺) 3.4 s (-7.49% 🔽) 7.6 s
polaris-viz-esm 173.41 KB (+0.01% 🔺) 3.5 s (+0.01% 🔺) 2.3 s (-26.88% 🔽) 5.7 s
polaris-viz-css 4.57 KB (0%) 92 ms (0%) 527 ms (-20.93% 🔽) 618 ms
polaris-viz-esnext 178.52 KB (+0.01% 🔺) 3.6 s (+0.01% 🔺) 2.5 s (-4.28% 🔽) 6.1 s

Copy link
Member

@maryamkaka maryamkaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📇

packages/polaris-viz/CHANGELOG.md Outdated Show resolved Hide resolved
@michaelnesen michaelnesen force-pushed the donut-chart-renderInnerValueContent-active-index branch from fed0db9 to 30a03f0 Compare October 2, 2023 15:29
@envex envex merged commit 3f45d06 into main Oct 2, 2023
@shopify-shipit shopify-shipit bot temporarily deployed to production October 2, 2023 16:19 Inactive
@pbojinov pbojinov added the #gsd:31444 Analytics Overview Dashboard Customization label Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#gsd:31444 Analytics Overview Dashboard Customization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants