Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove delay when isAnimated: false. Fix Tooltip z-index #1604

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

envex
Copy link
Collaborator

@envex envex commented Nov 14, 2023

What does this implement/fix?

BarChart would still have a staggered in animation even when isAnimated was false because we weren't setting the delay to 0.

Also fixes the tooltip z-index to match the polaris tooltip.

Resolves https://github.com/Shopify/core-issues/issues/63108

What do the changes look like?

Before

Screen.Recording.2023-11-14.at.1.14.39.PM.mov

After

Screen.Recording.2023-11-14.at.1.18.26.PM.mov

Storybook link

Note

There's an issue where we can't alter the controls in Storybook for some reason that I haven't dug into yet.

Before merging

  • Check your changes on a variety of browsers and devices.

  • Update the Changelog's Unreleased section with your changes.

  • Update relevant documentation, tests, and Storybook.

  • Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package

Copy link

github-actions bot commented Nov 14, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
polaris-viz-core-cjs 61.31 KB (+0.01% 🔺) 1.3 s (+0.01% 🔺) 891 ms (-27.16% 🔽) 2.2 s
polaris-viz-cjs 211.26 KB (+0.01% 🔺) 4.3 s (+0.01% 🔺) 2.1 s (-9.26% 🔽) 6.3 s
polaris-viz-esm 173.62 KB (+0.01% 🔺) 3.5 s (+0.01% 🔺) 1.4 s (+6.42% 🔺) 4.9 s
polaris-viz-css 4.57 KB (+0.18% 🔺) 92 ms (+0.18% 🔺) 256 ms (-14.22% 🔽) 348 ms
polaris-viz-esnext 178.73 KB (+0.01% 🔺) 3.6 s (+0.01% 🔺) 1.6 s (+5.89% 🔺) 5.2 s

@envex envex force-pushed the envex/remove-delay branch from 122b752 to f046310 Compare November 14, 2023 19:20
@envex envex requested a review from rita-morozova November 14, 2023 19:20
@envex envex merged commit 0298318 into main Nov 14, 2023
6 checks passed
@envex envex deleted the envex/remove-delay branch September 12, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants