Remove delay when isAnimated: false. Fix Tooltip z-index #1604
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
BarChart would still have a staggered in animation even when
isAnimated
wasfalse
because we weren't setting the delay to0
.Also fixes the tooltip z-index to match the polaris tooltip.
Resolves https://github.com/Shopify/core-issues/issues/63108
What do the changes look like?
Before
Screen.Recording.2023-11-14.at.1.14.39.PM.mov
After
Screen.Recording.2023-11-14.at.1.18.26.PM.mov
Storybook link
Note
There's an issue where we can't alter the controls in Storybook for some reason that I haven't dug into yet.
Before merging
Check your changes on a variety of browsers and devices.
Update the Changelog's Unreleased section with your changes.
Update relevant documentation, tests, and Storybook.
Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package