Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with data sets that are empty #1608

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Fix issue with data sets that are empty #1608

merged 1 commit into from
Nov 16, 2023

Conversation

envex
Copy link
Collaborator

@envex envex commented Nov 16, 2023

What does this implement/fix?

This fixes an issue that arose when bumping polaris-viz in web.

https://6062ad4a2d14cd0021539c1b-hywmloasex.chromatic.com/?path=/story/polaris-viz-charts-linechartrelational--no-benchmark-series

Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
polaris-viz-core-cjs 61.31 KB (0%) 1.3 s (0%) 1.1 s (+74.17% 🔺) 2.3 s
polaris-viz-cjs 211.37 KB (+0.01% 🔺) 4.3 s (+0.01% 🔺) 2.1 s (+10.43% 🔺) 6.3 s
polaris-viz-esm 173.67 KB (+0.01% 🔺) 3.5 s (+0.01% 🔺) 1.2 s (-10.73% 🔽) 4.6 s
polaris-viz-css 4.57 KB (0%) 92 ms (0%) 296 ms (-38.35% 🔽) 388 ms
polaris-viz-esnext 178.77 KB (+0.01% 🔺) 3.6 s (+0.01% 🔺) 1.3 s (+1.22% 🔺) 4.9 s

@envex envex requested a review from rita-morozova November 16, 2023 19:46
@envex envex merged commit e8efb76 into main Nov 16, 2023
4 checks passed
@envex envex deleted the envex/fill-bug-tests branch September 12, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants