Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework LineChartPredictive to use in chart LineSeries #1617

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Rework LineChartPredictive to use in chart LineSeries #1617

merged 1 commit into from
Jan 12, 2024

Conversation

envex
Copy link
Collaborator

@envex envex commented Jan 10, 2024 •
edited
Loading

What does this implement/fix?

Refactor LineSeriesPredictive to use real LineSeries components so we get all the functionality for each line.

@envex envex force-pushed the envex/predictive-refactor branch 2 times, most recently from 3816e9d to c50a694 Compare January 12, 2024 15:15
@envex envex marked this pull request as ready for review January 12, 2024 15:15
@envex envex force-pushed the envex/predictive-refactor branch from c50a694 to 53bcc7a Compare January 12, 2024 15:20
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 12, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
polaris-viz-core-cjs 61.35 KB (+0.08% 🔺) 1.3 s (+0.08% 🔺) 979 ms (-11.81% 🔽) 2.3 s
polaris-viz-cjs 213.36 KB (+0.21% 🔺) 4.3 s (+0.21% 🔺) 2.3 s (+25.54% 🔺) 6.6 s
polaris-viz-esm 174.01 KB (-0.64% 🔽) 3.5 s (-0.64% 🔽) 1.4 s (-29.51% 🔽) 4.9 s
polaris-viz-css 4.73 KB (+0.48% 🔺) 95 ms (+0.48% 🔺) 162 ms (-38.35% 🔽) 257 ms
polaris-viz-esnext 179.37 KB (-0.6% 🔽) 3.6 s (-0.6% 🔽) 1.3 s (-5.63% 🔽) 4.9 s

@envex envex force-pushed the envex/predictive-refactor branch 2 times, most recently from 480aa3f to bb10037 Compare January 12, 2024 17:30
@envex envex force-pushed the envex/predictive-refactor branch 2 times, most recently from 23c02cc to 238fe74 Compare January 12, 2024 18:01
@envex envex force-pushed the envex/predictive-refactor branch from 238fe74 to 1ccdfc2 Compare January 12, 2024 19:29
@envex envex merged commit 82b008b into main Jan 12, 2024
6 checks passed
@envex envex deleted the envex/predictive-refactor branch September 12, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylernoseworthy tylernoseworthy tylernoseworthy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@envex @tylernoseworthy