Allow bar chart to fill missing data even when comparisons are provided #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envex
commented
Jan 17, 2024
| const data = fillMissingDataPoints(dataSeries); | ||
| const data = fillMissingDataPoints( | ||
| dataSeries, | ||
| isValidDate(dataSeries[0]?.data[0]?.key), |
There was a problem hiding this comment.
Instead of passing a prop like isLinear we're going to naively check if a data point is a date.
size-limit report 📦
|
envex
force-pushed
the
envex/fill-non-linear-comparisons
branch
from
b90b6f2 to
29da89a
Compare
envex
force-pushed
the
envex/fill-non-linear-comparisons
branch
from
29da89a to
a4e414b
Compare
maryamkaka
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
When filling missing data we originally did not fill data that contained comparison data because we can't match the keys 1:1, which resulted in a
LineChartrendering with the lines apart from each other.With a
BarCharthaving (non linear) charts with comparison data is a validuse-case, so now we only want to ignore data that includes comparisons if the data is linear.Fixes issue with linear BarCharts crashing in https://github.com/Shopify/web/pull/114196
Storybook link
https://6062ad4a2d14cd0021539c1b-zoyhctyboe.chromatic.com/?path=/story/polaris-viz-charts-barchart-playground--mis-matched-web-data
Before merging
Check your changes on a variety of browsers and devices.
Update the Changelog's Unreleased section with your changes.
Update relevant documentation, tests, and Storybook.
Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package